Skip to content

Add validation for commits/PRs to main/staging #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
May 16, 2025

Conversation

jason-ng3
Copy link
Contributor

  1. Adds a GitHub Actions workflow, for which any push or pull request to staging or main with changed files in the templates directory will invoke a validation script, passing in all files for the affected vendor-product directory or directories.

  2. Adds the validation script which:

    • Checks that all required files are present.
    • Validates structure of and type checks asset YAML and manifest YAML using Pydantic library.
    • Validates cross-file references.
    • If validation does not pass, the event is rejected and logs print a list of the affected files and their respective errors.
  3. Tested script locally and then tested GitHub Actions with happy/error paths using pushes to this feature branch and pull requests from a test branch to this feature branch.

@jason-ng3 jason-ng3 requested a review from a team as a code owner May 14, 2025 16:39
jason-ng3 added 29 commits May 16, 2025 12:58
…from changed files, collect all files within directories, and validate them so any commit/pull request can be validated
…py (corrected collection_slug in monitors/matched-writes-license-exceeded.yaml)
@jason-ng3 jason-ng3 force-pushed the add-pr-commit-validation branch from b23a134 to b990a80 Compare May 16, 2025 17:01
@wziller wziller merged commit 8b92625 into staging May 16, 2025
@wziller wziller deleted the add-pr-commit-validation branch May 16, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants