Skip to content

Parsing preparations #1479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pitdicker wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Parsing preparations #1479

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3af5d5b
Use `format::parse` in `DateTime<FixedOffset>::from_str`
pitdicker Mar 2, 2024
94fcec0
Move `FromStr` impl to `datetime` module
pitdicker Mar 2, 2024
1dc14e0
Use `format::parse` in `FixedOffset::from_str`
pitdicker Mar 2, 2024
c2d3345
Simplify digit parsing in `timezone_offset`
pitdicker Mar 2, 2024
a799ecf
Support parsing negative timestamps
pitdicker Mar 2, 2024
3b7fa22
Remove duplicate checks
pitdicker Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/format/parse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,25 +424,16 @@ where
}

&Internal(InternalFixed { val: InternalInternal::Nanosecond3NoDot }) => {
if s.len() < 3 {
Copy link
Member

@djc djc Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in the commit message why they're duplicate (that is, how these invariants are upheld)? It's not clear in the diff.

return Err(TOO_SHORT);
}
let nano = try_consume!(scan::nanosecond_fixed(s, 3));
parsed.set_nanosecond(nano)?;
}

&Internal(InternalFixed { val: InternalInternal::Nanosecond6NoDot }) => {
if s.len() < 6 {
return Err(TOO_SHORT);
}
let nano = try_consume!(scan::nanosecond_fixed(s, 6));
parsed.set_nanosecond(nano)?;
}

&Internal(InternalFixed { val: InternalInternal::Nanosecond9NoDot }) => {
if s.len() < 9 {
return Err(TOO_SHORT);
}
let nano = try_consume!(scan::nanosecond_fixed(s, 9));
parsed.set_nanosecond(nano)?;
}
Expand Down