Add MP4 container support for muxing tracks #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a --mp4 option to produce MP4 containers when possible (H.264 video + AAC audio). The muxing logic now attempts to use ffmpeg for MP4 output if tracks are compatible, otherwise falls back to mkvmerge for MKV. Updates file extension handling and command-line options accordingly. ONLY TESTED IN DISNEYPLUS
|
Can I ask what is the usecase for this? MKV is vastly superior to MP4 and most releases nowadays are in MKV format. I'm not challenging you. It's probably a useful feature for someone. But I did want to know your reasoning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a --mp4 option to produce MP4 containers when possible (H.264 video + AAC audio).
The muxing logic now attempts to use ffmpeg for MP4 output if tracks are compatible, otherwise falls back to mkvmerge for MKV. Updates file extension handling and command-line options accordingly.
Example command:
.\.venv\Scripts\Activate.ps1; python .\vt.py dl --quality 1080 -a aac --alang es-ES -ns --mp4 DisneyPlus "https://www.disneyplus.com/es-es/browse/entity-23c8484e-a657-440b-8bf9-678f547331ff"NOTE: ONLY TESTED IN DISNEYPLUS & HULU, I need someone to test this with Netflix, Amazon, AppleTV and other services.