Skip to content

Conversation

@segeeslice
Copy link

Problem

When running the excel builder, an error would appear within XML Stringify, stating there was an improper header name.

Source

Upon investigation, the element names in question that caused the issue were 'fileVersion ' and 'workbookView '.

Looking at the regex in the XML package, these should not have the spaces in it to work as intended. I presume the XML package has updated at some point to not allow for these spaces.

Solution

Changed these headers to not include the trailing space.

@segeeslice
Copy link
Author

Admittedly, I have not researched much on the coding practices of this package. I would be glad to add the changes anywhere else as necessary.

@robert1233
Copy link

Would like a merge on this if possible @chuanyi . Removing those two spaces fixes it right up.

@protobi-pieter
Copy link

@robert1233 Can you see if this works on branch https://github.com/protobi/msexcelbuilder and if not file a similar PR?

@robert1233
Copy link

That works as far as the above issue is concerned! @pietersv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants