Skip to content

Commit

Permalink
Merge pull request #96 from weaponsforge/dev
Browse files Browse the repository at this point in the history
Feat/weaponsforge 92 - Follow-up
  • Loading branch information
ciatph authored Aug 28, 2024
2 parents dbe6dae + 774a94e commit cec3773
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,8 @@ jobs:
name: Publish to NPM registry
runs-on: ubuntu-latest
needs: build-on-win
env:
IMAGE_URL: ${{ secrets.IMAGE_URL }}
steps:
- name: Checkout the repository
uses: actions/checkout@v3
Expand Down
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ The following dependencies are used for this project. Feel free to use other dep
| SHEETJS_COLUMN | Column name read by [sheetjs](https://sheetjs.com/) in an excel file.<br>This column contains the municipality and province names following the string pattern<br>`"municipalityName (provinceName)"`<br>Default value is `__EMPTY`|
| SORT_ALPHABETICAL | Arranges the municipality names in alphabetical order.<br>Default value is `1`. Set to `0` to use the ordering as read from the Excel file. |
| SPECIAL_CHARACTERS | Key-value pairs of special characters or garbled text and their normalized text conversions, delimited by the `":"` character.<br>Multiple key-value pairs are delimited by the `","` character.<br>If a special character key's value is a an empty string, write it as i.e.,: `"some-garbled-text:"` |
| IMAGE_URL | Raw URL of the README image file from this GitHub repository.<br> <blockquote>**NOTE:** Only add this variable in the GitHub Secrets for publishing to the NPM registry since NPM does not allow displaying images by relative path.</blockquote> |
## Installation Using Docker
Expand Down
3 changes: 2 additions & 1 deletion app/.env.example
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,5 @@ EXCEL_FILE_URL=https://pubfiles.pagasa.dost.gov.ph/pagasaweb/files/climate/tenda
DEFAULT_EXCEL_FILE_URL=https://pubfiles.pagasa.dost.gov.ph/pagasaweb/files/climate/tendayweatheroutlook/day1.xlsx
SHEETJS_COLUMN=__EMPTY
SORT_ALPHABETICAL=1
SPECIAL_CHARACTERS=├â┬▒:ñ,â:
SPECIAL_CHARACTERS=├â┬▒:ñ,â:
IMAGE_URL=https://raw.githubusercontent.com/ciatph/ph-municipalities/master/docs/diagrams/ph-municipalities-arch-90.png
4 changes: 2 additions & 2 deletions scripts/npm-publish.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash

sed "s|/docs/diagrams/||g" README.md > app/README.md
cp docs/diagrams/ph-municipalities-arch-90.png app/
# Use image file from remote URL source since NPM does not allow displaying images by relative path
sed "s|/docs/diagrams/ph-municipalities-arch-90.png|${IMAGE_URL}|g" README.md > app/README.md

0 comments on commit cec3773

Please sign in to comment.