Start migrating to typescript #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still on my radar, but I will not get to it probably until a week from today. |
|
@chriskrycho This kind of works, but apparently we should compile to JS + d.ts before publish. Any idea how we do that? |
|
I do have some thoughts on that, but I have not had a chance to play with any of them yet.
|
|
@cibernox if I'm starting on integration with ember-cli-typescript, is this still a reasonable branch? (I see that it's many months out of date, but don't know how much things have diverged otherwise.) |
|
Probably no. I'd start over, and maybe, just maybe, use it for inspiration. Besides, chances are your typescript annotation will be more idiomatic. |
|
Cool. I may give it a whirl today or tomorrow and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works!! 🎉 🎉 🎉
Don't merge this yet.