request to add wedaly to azure team #181
Conversation
Signed-off-by: Will Daly <widaly@microsoft.com>
|
@cilium/azure |
|
this PR is approved by multiple members of @cilium/azure , would anyone be able to merge it? Thanks! |
|
It seems not all Committers have permissions to merge 🤔 |
|
@pchaigno I've updated the setting so all committers should be able to merge now |
|
@xmulligan I've reversed that because it's not yet quite enough to just merge the commit, there needs to be action on the backend to make it happen. @jspaleta and I are working on automating that better at the moment based directly on the contents of this repo. There's good progress in the last few weeks but it's not quite there yet. I'll do a quick check of all PRs merged recently to make sure they apply as expected. |
|
@aanm does your feedback from #184 (review) apply for @wedaly as well? I want to make sure that we're setting a consistent bar and applying it the same for everyone. Given that this PR doesn't have any links to contributions and the approvers have not made any statements about how they're thinking about the review bar and @wedaly's contributions, it's not obvious to me whether the approvers have observed more from @wedaly's contributions or if we are not being consistent with how we approve reviewers. |
|
Thinking a bit more on the above - we've struggled to populate the team in the past, so I think it's valuable for us to have contributors willing to help with this. @tamilmani1989 and @wedaly are both actively involved in the project in general, though they may not have made significant changes specifically to this area (Most relevant I can think of is delegated IPAM from Will). Given the low frequency of changes, it can be difficult to provide opportunities for new people to contribute and step up to the bar we would usually set for reviewers. One of the goals in general for reviewers from my perspective is that people who are reviewers in a specific code area should be familiar with working with one another, reviewing at a consistent level, and sharing the ownership / maintenance. However, if the existing reviewers @tommyp1ckles and @hemanthmalla are happy with working with these two within the context of this codeowner group, then that seems like a reasonable argument to admit both of them. |
|
Maybe the key thing that would help to resolve my question above is just the pointers to specific contributions in any cilium/community PR so that we can more transparently make these decisions. |
|
I'll quickly add one example of the kind of value we can provide as reviewers for Azure SIG (and the original motivation for opening this PR): cilium/cilium#36379 (comment) |
|
@wedaly I see, thanks for sharing. That sort of insight and help with how we maintain the Azure logic in Cilium is what I think we're looking for when admitting members into this group. Other bugfixes, SDK updates, etc would be good examples to share as well. |
|
Sorry about that 😓 I appreciate the automation you are putting into place |
Volunteering myself to help with anything Azure-related.