-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tamilmani1989 and wedaly to new cilium-cni group #182
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Tamilmani <tamanoha@microsoft.com>
Hi @tamilmani1989 , thanks for helping to maintain Cilium 🎉 . I think this will need a bit more discussion. Some things that would help:
|
since delegated ipam is part of CNI spec, i inclined to create
I'm not sure whom to add that's why didn't add other ppl. Let me check owner of those files |
looks like plugin/cilium-cni is owned by @cilium/sig-k8s and sig-k8s owns several other stuff. https://github.com/cilium/cilium/blob/fb5cf48a42e15a3c5cd01aeb880edd7682d59961/CODEOWNERS#L618C22-L618C37 |
I could maybe see an argument for why CNI should have its own group. It's @cilium/sig-k8s adjacent but IMO doesn't exactly neatly fall into that bucket (the CNI spec is not actually part of k8s). As a reviewer, @cilium/sig-k8s can feel broad at times, getting load balanced for reviewing a cilium-cni change would be more of a context switch for me than a typical k8s type change (i.e. watchers, CRD specs, etc...). cc @squeed |
Just revisiting this fresh in the new year, to reiterate my understanding of the latest on this topic:
|
Would like to create new group for cilium cni and add myself and @wedaly as part of it since we contributed to delegated ipam and continue to participate in reviews and PRs related to this area