Add PR template for moving up the contributor ladder #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR template for people requesting to become org members and reviewers to clarify what information is helpful when opening the PR As discussed in #180 (comment) Signed-off-by: Bill Mulligan <[email protected]>
joestringer
reviewed
Jan 17, 2025
There was a problem hiding this comment.
The content looks good to me, though I wonder if it's worth trying to format this a bit more interactively, closer to the Cilium bug report template. When people unfamiliar with a template interact with it, sometimes they end up just leaving the templated text in the issue because they don't understand what they are expected to do with the templated text, and the result is that reviewers have to go back and ask the person to update their response to properly address the questions we are looking to be answered in the template. I think we've had pretty good experience with the UX from the Cilium bug report template.
| @@ -0,0 +1,24 @@ | |||
| # Moving up the [Contributor Ladder](https://github.com/cilium/community/blob/main/CONTRIBUTOR-LADDER.md) | |||
|
|
|||
| ``` | |||
There was a problem hiding this comment.
Looking at the rendered version, this verbatim formatting is causing the links below to not be rendered correctly.
xmulligan
added a commit
that referenced
this pull request
Jan 22, 2025
PR template for people requesting to become org members and reviewers to clarify what information is helpful when opening the PR Replaces #190 with a fillable template Signed-off-by: Bill Mulligan <[email protected]>
|
closing in favor of #191 |
joestringer
pushed a commit
to joestringer/cilium-community
that referenced
this pull request
Jan 23, 2025
PR template for people requesting to become org members and reviewers to clarify what information is helpful when opening the PR Replaces cilium#190 with a fillable template Signed-off-by: Bill Mulligan <[email protected]>
xmulligan
added a commit
that referenced
this pull request
Jan 24, 2025
PR template for people requesting to become org members and reviewers to clarify what information is helpful when opening the PR Supersedes #190 and #191 I’ve considered various approaches to formatting this but landed on the current one for simplicity. Initially, I thought about making this an issue template, but requiring contributors to open an issue before a PR felt unnecessarily complex and could lead to confusion. For reference, #190 included an additional top section that I’ve since removed, as it added extra wording without providing new information beyond what’s already covered in the ladder. I also explored creating multiple templates, but that seemed confusing too—contributors would need to know the correct URLs for each template. This solution isn’t perfect since it applies to the entire repository, including SIGs and sub-repositories. However, I expect external contributors to interact with those less frequently, and internal contributors will likely bypass the template where necessary. Signed-off-by: Bill Mulligan <[email protected]>
joestringer
pushed a commit
that referenced
this pull request
Jan 27, 2025
PR template for people requesting to become org members and reviewers to clarify what information is helpful when opening the PR Supersedes #190 and #191 I’ve considered various approaches to formatting this but landed on the current one for simplicity. Initially, I thought about making this an issue template, but requiring contributors to open an issue before a PR felt unnecessarily complex and could lead to confusion. For reference, #190 included an additional top section that I’ve since removed, as it added extra wording without providing new information beyond what’s already covered in the ladder. I also explored creating multiple templates, but that seemed confusing too—contributors would need to know the correct URLs for each template. This solution isn’t perfect since it applies to the entire repository, including SIGs and sub-repositories. However, I expect external contributors to interact with those less frequently, and internal contributors will likely bypass the template where necessary. Signed-off-by: Bill Mulligan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR template for people requesting to become org members and reviewers to clarify what information is helpful when opening the PR
As discussed in #180 (comment)