Merged
Conversation
lizrice
approved these changes
Nov 28, 2025
Member
|
I’ve approved the change in theory, but it obvs also needs to pass whatever the linter is complaining about 😀 |
Member
|
The linter is suggesting a change to ensure that @cilium/community will be pinged on PRs in this repository if someone posts a PR to join or leave the @cilium/community team. |
joestringer
approved these changes
Dec 1, 2025
Member
joestringer
left a comment
joestringer
left a comment
There was a problem hiding this comment.
LGTM, other than the linter failure
Looking at the reviewers for cilium/cilium#42913, I realized the community team isn't defined in this folder https://github.com/orgs/cilium/teams/community. Used the existing group minus tgraf as he isn't reviewing much any more. Signed-off-by: Bill Mulligan <[email protected]> Signed-off-by: Joe Stringer <[email protected]>
joestringer
force-pushed
the
xmulligan-patch-3
branch
from
08cb070 to
e9ecb21
Compare
Member
|
We might want to revisit https://github.com/cilium/community/blob/main/roles/Community-Team.md and consider deleting that file too. |
Member
Author
|
updated here #358 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking at the reviewers for cilium/cilium#42913, I realized the community team isn't defined in this folder https://github.com/orgs/cilium/teams/community. Used the existing group minus tgraf as he isn't reviewing much anymore