Use DeferAcyclicVerification() #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uber/dig defaults to checking for cycles on each Provide() call, which on large graphs becomes pretty expensive (cilium-agent is getting into multiple seconds now). To speed things up, set the DeferAcyclicVerification option on the dig container. Here's the effect on TestAgentCells in cilium/cilium: Before: daemon/cmd$ go test . -test.run TestAgentCell -test.count 1 ok github.com/cilium/cilium/daemon/cmd 3.674s After: daemon/cmd$ go test . -test.run TestAgentCell -test.count 1 ok github.com/cilium/cilium/daemon/cmd 0.192s Signed-off-by: Jussi Maki <[email protected]>
bimmlerd
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uber/dig defaults to checking for cycles on each Provide() call, which on large graphs becomes pretty expensive (cilium-agent is getting into multiple seconds now). To speed things up, set the DeferAcyclicVerification option on the dig container (cycles are checked on each Invoke).
Here's the effect on TestAgentCells in cilium/cilium:
Before:
After: