Hive script #17
Merged
Hive script #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Extended usage in cilium/statedb#57 More example usage in https://github.com/cilium/cilium/pull/35154/files |
joamaki
force-pushed
the
pr/joamaki/script
branch
3 times, most recently
from
e42dd02 to
bba2710
Compare
joamaki
force-pushed
the
pr/joamaki/script
branch
3 times, most recently
from
3cbab08 to
020e486
Compare
joamaki
requested review from
aanm and
christarazi
and removed request for
a team
joamaki
force-pushed
the
pr/joamaki/script
branch
from
020e486 to
e71815f
Compare
|
sorry for the reviewer noise, bumped Go to v1.23 in this PR and then realized it's a bad idea to bump it for solely being able to use the "maps" package (especially as we have older cilium releases using hive and deps being bumped), so reverted that change. |
ovidiutirla
reviewed
Oct 8, 2024
ovidiutirla
approved these changes
Oct 8, 2024
Vendor in the rsc.io/script library. As it was essentially a code dump out from go's internals and is unmaintained by rsc, it's easiest to vendor it here. It is vendored into cilium/hive instead of its own repo as its use and extensions will be somewhat coupled with hive. As first extension, add support for interactive use that doesn't wait for the section end. Signed-off-by: Jussi Maki <[email protected]>
joamaki
force-pushed
the
pr/joamaki/script
branch
from
e71815f to
fc01caf
Compare
Add the ScriptCmd* types for providing script commands within hive and the ScriptCommands() method for pulling them out from *Hive. Signed-off-by: Jussi Maki <[email protected]>
joamaki
force-pushed
the
pr/joamaki/script
branch
from
fc01caf to
a5b8462
Compare
Command for showing or grepping the output from the simple module health that allows testing the health reporting of a cell. Signed-off-by: Jussi Maki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendors in rsc.io/script and adds the facility to collect script commands from the hive.
For example usage see
replCmdinexample/main.goandshowEventsCommandinexample/events.go.