socket_options: small cleanup regarding setting socket options (IP_TRANSPARENT & SO_REUSEADDR) #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mhofstetter
commented
Dec 19, 2024
•
mhofstetter
commented
This commit reduces boilerplate by reducing the different codepaths for setting the IP_TRANSPARENT socket option for IPv4 & IPv6. Signed-off-by: Marco Hofstetter <[email protected]>
This commit moves the comment about setting SO_REUSEADDR socket option to the code that is actually setting the option. Signed-off-by: Marco Hofstetter <[email protected]>
mhofstetter
force-pushed
the
pr/mhofstetter/bpfmetadata-rem-iptrans-boilerplate
branch
from
f1236fb to
4e79729
Compare
mhofstetter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.