tetragon/windows: Add default definitions for Windows #3538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ExceptionalHandler
force-pushed
the
build/windows/defaults
branch
from
b08525e to
874c458
Compare
Moved over defaults.go to defaults_linux.go Added defaults_windows.go to add set of default paths and names for Windows. Some default definitions are stubbed out for compilation. Signed-off-by: Anadi Anadi <[email protected]>
ExceptionalHandler
force-pushed
the
build/windows/defaults
branch
from
874c458 to
9ec04bd
Compare
ExceptionalHandler
added
the
release-note/minor
jrfastab
reviewed
Apr 1, 2025
| DefaultMapPrefix = "tetragon" | ||
|
|
||
| // DefaultEventMap is the default name of the Event map | ||
| DefaultEventMap = "tcpmon" |
There was a problem hiding this comment.
perhaps map names can be shared?
jrfastab
reviewed
Apr 1, 2025
|
|
||
| // defaults for the event cache | ||
| DefaultEventCacheNumRetries = 15 | ||
| DefaultEventCacheRetryDelay = 2 |
There was a problem hiding this comment.
same here I'm not sure why these would actually be different?
jrfastab
approved these changes
Apr 1, 2025
|
I'll merge this, I do wonder a bit why Windows would end up with different defaults for some of those things in the comments above. It makes sense unify them later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved over
defaults.gotodefaults_linux.go.Added
defaults_windows.goto add set of default paths and names for Windows.Some default definitions are stubbed out for compilation.
Changelog