Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon/widows: Add signal translation for Windows #3547

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

ExceptionalHandler
Copy link
Contributor

Description

Windows signal handler requires specific map to identify signal codes and convert into code and string. This PR adds that map and implements the signal code to string conversion

Windows signal handler requires specific map to identify signal codes and convert into code and string.
This PR adds that map and implements the sinal-code-to-string conversion

Signed-off-by: Anadi Anadi <[email protected]>
@ExceptionalHandler ExceptionalHandler requested a review from a team as a code owner March 21, 2025 15:52
@ExceptionalHandler ExceptionalHandler added the release-note/minor This PR introduces a minor user-visible change label Mar 25, 2025
Copy link
Contributor

@jrfastab jrfastab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK but surely there is a standard pkg for this we could use instead?

@jrfastab
Copy link
Contributor

jrfastab commented Apr 2, 2025

Signal translation is included from unix pkg which doesn't make sense to use in _windows pkgs.

@jrfastab jrfastab merged commit 9616fe6 into cilium:main Apr 2, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants