[v1.2] watcher: Fix pod lookup if the index is out-of-sync #3551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
kind/backport
ghost
self-requested a review
as a 
olsajiri
approved these changes
Mar 24, 2025
[ upstream commit: 1df304f ] [ backporter's notes: On the upstream branch this change was done in a different file, pod.go, as the functions got moved there in the meantime. ] The K8sWatcher.FindPod method first tries to find a pod using index, then, if unsuccessful, falls back to walking the entire pods list. This fallback was incorrect - fix it. Signed-off-by: Anna Kapuscinska <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3409