-
Notifications
You must be signed in to change notification settings - Fork 492
tetragon/windows: Run unit tests on Windows #3637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon/windows: Run unit tests on Windows #3637
Conversation
2e61f1a to
4cb6357
Compare
mtardy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey, sorry I'm saying again the same thing but why don't you use the existing workflow, adding windows in the strategy matrix? https://github.com/cilium/tetragon/blob/main/.github/workflows/gotests.yml
😄 This is draft PR so I don't have to wait for UTs above to pass. I will add in existing Yaml. |
4cb6357 to
a9a5b92
Compare
This PR enabled running unit tests on Windows on a windows-latest runner. Tests are run on cmd and pkg folders Signed-off-by: Anadi Anadi<[email protected]>
a9a5b92 to
1357cfb
Compare
This commit adds tetragon.exe as a file to be deleted when make clean is called. Signed-off-by: Anadi Anadi <[email protected]>
This commit removes an environment variable not removed in a previous commit Signed-off-by: Anadi Anadi <[email protected]>
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have made these changes and some more from previous PRs |
Description
This PR enabled running unit tests on Windows on a windows-latest runner. Tests are run on cmd and pkg folders