Skip to content

Conversation

@ExceptionalHandler
Copy link
Contributor

@ExceptionalHandler ExceptionalHandler commented Apr 14, 2025

Description

This PR enabled running unit tests on Windows on a windows-latest runner. Tests are run on cmd and pkg folders

@ExceptionalHandler ExceptionalHandler added the release-note/ci This PR makes changes to the CI. label Apr 14, 2025
@ExceptionalHandler ExceptionalHandler force-pushed the v/ci/windows/unit-tests branch 13 times, most recently from 2e61f1a to 4cb6357 Compare April 14, 2025 23:27
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, sorry I'm saying again the same thing but why don't you use the existing workflow, adding windows in the strategy matrix? https://github.com/cilium/tetragon/blob/main/.github/workflows/gotests.yml

@ExceptionalHandler
Copy link
Contributor Author

hey, sorry I'm saying again the same thing but why don't you use the existing workflow, adding windows in the strategy matrix? https://github.com/cilium/tetragon/blob/main/.github/workflows/gotests.yml

😄 This is draft PR so I don't have to wait for UTs above to pass. I will add in existing Yaml.

This PR enabled running unit tests on Windows on a windows-latest runner.
Tests are run on cmd and pkg folders

Signed-off-by: Anadi Anadi<[email protected]>
This commit adds tetragon.exe as a file to be deleted when make clean is called.

Signed-off-by: Anadi Anadi <[email protected]>
This commit removes an environment variable not removed in a previous commit

Signed-off-by: Anadi Anadi <[email protected]>
@netlify
Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit f6c8748
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/67feaed5e0085600085065c1
😎 Deploy Preview https://deploy-preview-3637--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ExceptionalHandler ExceptionalHandler marked this pull request as ready for review April 15, 2025 20:37
@ExceptionalHandler ExceptionalHandler requested a review from a team as a code owner April 15, 2025 20:37
@ExceptionalHandler
Copy link
Contributor Author

hey, sorry I'm saying again the same thing but why don't you use the existing workflow, adding windows in the strategy matrix? https://github.com/cilium/tetragon/blob/main/.github/workflows/gotests.yml

😄 This is draft PR so I don't have to wait for UTs above to pass. I will add in existing Yaml.

I have made these changes and some more from previous PRs

@ExceptionalHandler ExceptionalHandler merged commit 4dbcdd4 into cilium:main Apr 22, 2025
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note/ci This PR makes changes to the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants