Bones + TriMesh/VboMesh fixes #2313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
geom::BONE_INDEXandgeom::BONE_WEIGHTtoTriMesh. It currently assumes that bone indices are limited to 4 bones, and that they are stored in floating point values rather than integers. Adding support for integer-based bone indices will require changes to a lot of the internalgeommachinery and can be worked around for now. We'll plan to revisit this at some point in the future however.TriMeshandgl::VboMeshignored thestrideBytesparameter on copyAttrib when they were being loaded through ageom::Target. This is now fixed.