fix(driver): schedule timeout upon CommitCertificate for invalid value#1481
Merged
romac merged 7 commits intocirclefin:mainfrom Feb 25, 2026
Merged
fix(driver): schedule timeout upon CommitCertificate for invalid value#1481romac merged 7 commits intocirclefin:mainfrom
CommitCertificate for invalid value#1481romac merged 7 commits intocirclefin:mainfrom
Conversation
cason
requested review from
ancazamfir,
nenadmilosevic95 and
romac
and removed request for
ancazamfir and
romac
This comment was marked as outdated.
This comment was marked as outdated.
romac
reviewed
Feb 17, 2026
| match self.store_and_multiplex_commit_certificate(certificate) { | ||
| Some(round_input) => self.apply_input(round, round_input), | ||
| None => Ok(None), | ||
| None => Ok(None), // FIXME: Any scenario where this can happen? |
Contributor
There was a problem hiding this comment.
I think we can now change the return type of store_and_multiplex_commit_certificate to RoundInput<Ctx> and simplify this.
nenadmilosevic95
approved these changes
Feb 25, 2026
Contributor
nenadmilosevic95
left a comment
nenadmilosevic95
left a comment
There was a problem hiding this comment.
LGTM! Nice catch!
romac
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1482
Minor fix for the logic commented below, which is not applied if the proposal is not valid, only if not found:
malachite/code/crates/core-driver/src/mux.rs
Lines 225 to 228 in ea0809d
Test unit updated in order to fail in the case a
CommitCertificateis received for an invalid valuev.