Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Resource Limit Issue with Deployment to DMZ #512

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Aug 1, 2024

🗣 Description

Mark aws-sdk v2 and its associated dependencies as dev dependencies.

💭 Motivation and context

This addresses a deployment issue related to the unzipped lambda package being too large.
Closes issue #511
aws-sdk version 2 is preinstalled in the Node 16 lambda image. By marking it as a dev dependency, we reduce the size of the Scan Execution lambda.

See more about preinstalled packages here.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Aug 1, 2024 that may be closed by this pull request
@Matthew-Grayson Matthew-Grayson changed the title Mark aws-sdk as a dev dependency. Fix Resource Limit Issue with Deployment to DMZ Aug 1, 2024
@Matthew-Grayson Matthew-Grayson self-assigned this Aug 1, 2024
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review September 6, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan Execution Lambda is Too Large
1 participant