-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create CSA region-to-email mapping YAML file for cisagov/cyhy-mailer
#749
Conversation
This file is required as of cisagov/cyhy-mailer#101.
0d2fdd5
to
1ca6c51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
Please see my one minor change request.
Co-authored-by: dav3r <[email protected]>
Hi Team, one medium severity issue at terraform_egress_pub/cloudfront.tf line 144, detected an AWS CloudFront Distribution with an insecure TLS version. TLS versions less than 1.2 are considered insecure because they can be broken. To fix this, set minimum_protocol_version to "TLSv1.2_2018", "TLSv1.2_2019", or "TLSv1.2_2021". |
Hi Team, one potential medium severity issue at terraform/ files bod_vpc_flow_logs.tf, cyhy_vpc_flow_logs.tf, and mgmt_vpc_flow_logs.tf each file at line 43, aws-cloudwatch-log-group-no-retention. The AWS CloudWatch Log Group has no retention. Missing retention in log groups can cause losing important event information. |
The issue you bring up has nothing to do with this pull request, but I created #750 to capture your concern. |
The issue you bring up has nothing to do with this pull request, but I created #751 to capture your concern. |
@jsf9k I forgot to ask this earlier, but did you already populate the correct CSA/email YAML in SSM ( |
🗣 Description
This pull request makes the necessary changes to create the CSA region-to-email mapping YAML file now required by cisagov/cyhy-mailer as of cisagov/cyhy-mailer#101.
Note that I added the appropriate YAML to the SSM Parameter Store variable
/cyhy/csa_email_yaml
to the CyHy AWS account in all four US regions.💭 Motivation and context
Partly resolves cisagov/cyhy-system#114. See also cisagov/cyhy-mailer#101.
🧪 Testing
All automated tests pass.
✅ Pre-approval checklist