Test existing script to associate domain requests with their portfolio

[katypies]

Issue description

Now that we have portfolios for FEB (Federal Executive Branch) agencies, we should make sure any domain requests for the FEB agencies are part of these portfolios. This sub-issue is to test the script modified in #3117 and modify if if we need changes.
edit: We will no longer be doing this for all FEBs, instead we want to add domain requests to a portfolio one portfolio at a time.

Acceptance criteria

• Test and if necessary modify the script to add domain requests for FEB agencies to their portfolio
• Modify the script to add data to the following fields (missing data):
  • requested_suborganization, suborganization_city, suborganization_state_territory
  • Note that requested_suborganization should be pulling from organization_name
• Modify script to remove the federal agency value from started domain requests that match this federal agency
• Change current script to trim suborg names before creating suborgs and which will not create "duplicate" suborg values
• Test this on ag or another sandbox with a large amount of data
• Evaluate the impact of running this script for users (analysts and registrar) and inform a dev lead on the following
  • some users will not be part of portfolios yet, but their requests will be in a portfolio, check the non-org model view and evaluate if there is any impact to these users such as data change, being able to submit, etc.
  • for these users not in the portfolio, use your own judgement to evaluate their user experience and determine if additional things should be considered
  • check domain requests exports, some of this is using conditional logic, could this have an impact on reports that we should address?
  • after running this script if a submitted request is marked as "ineligible" is there anyway to easily remove it from the agencies portfolio?
  • is there a negative impact on the analyst view for submitted domain requests? Domain requests have different fields for org model and non org model, but on django admin we automatically show a org model view of the domain request to analysts if the request has a portfolio. Do they then see missing data (such as suborganization, anything else, etc )? Are analysts still able to adjust fields and approve/reject the requests per the usual?

Related Issues

• ⤴ This is a sub-issue of Add domain requests to organizations #3233
• 🔄 Relates to Create all Federal Executive Branch portfolios #3110
• 🚫 Blocks Run portfolio-domain request script on Staging #3236
• 🚫 Blocks Run script on Stable #3235

[allly-b]

Seeing this ticket now, as it was in a bundle ticket and the bundle ticket did not have "dev" on it. We should not include domain requests that are marked as ineligible when adding requests to the portfolio, as those were invalid domain requests that were sent.

Running this script, will not mean that new domain requests get automatically added to the portfolio. We would need to re-run this script for the given agency before adding them to our system (or manually check and add new domain requests). I would discourage from running this script for all FEB unless we have a use case to do so, neither the parent nor this ticket really describe a use case for why this is needed or helpful to do, which would be helpful to add in. I would instead suggest running this on a per agency basis to avoid just having to re-run it or manual check for new data. Unless, of course the plan is to just have analysts manually add requests to validated domain requests as that would also solve the problem of missing new requests that come through.

Running this script now would also make some submitted data hidden to analysts such as additional contacts, "Anything else", etc as the system will assume they are part of the org model. For domain requests in review, in action needed and submitted, has this apparent "data loss" been discussed and agreed acceptable?

CC: @lizpearl and @katypies

[zandercymatics]

@abroddrick Added an AC to specify that we should be adding requested suborg fields