Create /var/spool/postfix/etc/ and /var/spool/postfix/private/ if they don't exist.#55
Open
jroose wants to merge 5 commits intocisagov:developfrom
Open
Create /var/spool/postfix/etc/ and /var/spool/postfix/private/ if they don't exist.#55jroose wants to merge 5 commits intocisagov:developfrom
jroose wants to merge 5 commits intocisagov:developfrom
Conversation
jroose
requested review from
dav3r,
felddy,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
jsf9k
added
the
improvement
Member
|
Thanks for the contribution @jroose! |
jsf9k
requested changes
Sep 8, 2025
Member
jsf9k
left a comment
jsf9k
left a comment
There was a problem hiding this comment.
Requesting a couple of very minor changes.
|
|
||
| # postfix needs fresh copies of files in its chroot jail | ||
| if [ ! -e /var/spool/postfix/etc ]; then | ||
| mkdir /var/spool/postfix/etc |
Member
There was a problem hiding this comment.
Suggested change
| mkdir /var/spool/postfix/etc | |
| mkdir --parents /var/spool/postfix/etc |
| mkdir /var/spool/postfix/etc | ||
| fi | ||
| if [ ! -e /var/spool/postfix/private ]; then | ||
| mkdir /var/spool/postfix/private |
Member
There was a problem hiding this comment.
Suggested change
| mkdir /var/spool/postfix/private | |
| mkdir --parents /var/spool/postfix/private |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This change creates
/var/spool/postfix/etcand/var/spool/postfix/privateif they do not exist.💭 Motivation and context
The documentation recommends using
/var/spool/postfixas a volume, but if an empty directory gets mounted there, then the./etcand./privatedirectories don't exist and the entrypoint fails.🧪 Testing
I just built the container, pushed it to my registry, and ran it on my K8S cluster. It no longer threw an error.
✅ Pre-approval checklist
✅ Pre-merge checklist
✅ Post-merge checklist