Add a lower-bound pin for the flake8-docstrings pip package
#184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
dependencies
jsf9k
requested review from
dav3r,
felddy,
jasonodoom and
mcdonnnj
as code owners
dv4harr10
approved these changes
Jul 1, 2024
dav3r
approved these changes
Jul 2, 2024
mcdonnnj
requested changes
Aug 24, 2024
Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general. The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version. Co-authored-by: Nick <[email protected]>
dav3r
approved these changes
Aug 26, 2024
mcdonnnj
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
I noticed that
flake8-docstringsis listed as an additional dependency offlake8in thepre-commitconfiguration, but pinning is done.💭 Motivation and context
@mcdonnnj agreed with me that it makes sense to at least perform some minimal pinning to ensure that a working version of
flake8-docstringsis installed.🧪 Testing
All automated tests pass. I also verified that there are no other additional dependencies in the
pre-commitconfiguration that do no at least have a lower-bound pin.✅ Pre-approval checklist