Skip to content

Use a version tag for cisagov/setup-env-github-action #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request updates the reference for the cisagov/setup-env-github-action action to reference a tag instead of a branch. Specifically it uses the tag for the current major version.

💭 Motivation and context

Now that the cisagov/setup-env-github-action has appropriate tags we should use them just as we do for other GitHub actions we use in our workflows.

🧪 Testing

Automated tests pass. I verified that expected values are being supplied to actions that rely on the versions provided by the cisagov/setup-env-github-action action.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

We currently use the `develop` branch as our reference for the
cisagov/setup-env-github-action action in the build workflow. We will
instead use the major version tag which puts our usage of this action
in line with how we use other actions in our workflows.
@mcdonnnj mcdonnnj requested review from a team and Copilot May 28, 2025 15:31
@mcdonnnj mcdonnnj self-assigned this May 28, 2025
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner May 28, 2025 15:31
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 28, 2025
@mcdonnnj mcdonnnj requested review from felddy and jsf9k as code owners May 28, 2025 15:31
@mcdonnnj mcdonnnj added the github-actions Pull requests that update GitHub Actions code label May 28, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The purpose of this PR is to update the workflow configuration to use a tagged version of the cisagov/setup-env-github-action instead of referencing the branch.

  • Replace branch reference "develop" with version tag "v1" in the GitHub Actions workflow for environment setup.

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Skeleton Maintenance May 28, 2025
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

4 participants