Skip to content

Add a configuration block for pre-commit.ci #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented May 28, 2025

🗣 Description

This pull request adds a ci block to the pre-commit configuration to provide configuration information to the pre-commit.ci GitHub app.

💭 Motivation and context

I am looking to install the app in our organization for just this repository to automate pull requests to update pre-commit hooks in our configuration much like we have with dependabot for other dependencies. However, there are some configuration specifics that need to be in place before we install the app. If autofix functionality is desired I think our best path forward given the aforementioned limitation on what the pre-commit.ci app can access is the lite version that ties into GitHub Actions to function.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Install the pre-commit.ci GitHub app in the organization with permission to access this repository.

This adds a `ci` block to the pre-commit configurations to control the
behavior of the pre-commit.ci GitHub app.
@mcdonnnj mcdonnnj requested review from a team and Copilot May 28, 2025 15:35
@mcdonnnj mcdonnnj self-assigned this May 28, 2025
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 28, 2025
@mcdonnnj mcdonnnj requested review from dav3r, felddy and jsf9k as code owners May 28, 2025 15:35
@mcdonnnj mcdonnnj added the dependencies Pull requests that update a dependency file label May 28, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new ci configuration block in .pre-commit-config.yaml to support pre-commit.ci integration by specifying settings for autofix PRs and autoupdate schedule.

  • Adds a "ci" block with autofix_prs set to false.
  • Configures autoupdate_schedule to weekly.

@github-project-automation github-project-automation bot moved this from In progress to Reviewer approved in Skeleton Maintenance May 28, 2025
@mcdonnnj mcdonnnj added the kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release label May 28, 2025
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Status: Reviewer approved
Development

Successfully merging this pull request may close these issues.

4 participants