Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comment to reflect the correct version of Alpine Linux #111

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request updates a comment to reflect the correct version of Alpine Linux.

💭 Motivation and context

In #109 I updated the version of Alpine Linux used in the configuration but neglected to update the comment in the build workflow for platform limitations. The limitations have not changed but we should reference the correct OS version we are using.

🧪 Testing

Automated tests pass. 👀

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

In #109 I updated the version of Alpine Linux used in the configuration
but neglected to update the comment in the `build` workflow for
platform limitations. The limitations have not changed but we should
reference the correct OS version we are using.
@mcdonnnj mcdonnnj added bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation labels Jan 17, 2025
@mcdonnnj mcdonnnj self-assigned this Jan 17, 2025
@mcdonnnj mcdonnnj requested a review from a team January 17, 2025 19:53
@mcdonnnj mcdonnnj enabled auto-merge January 17, 2025 19:54
@mcdonnnj mcdonnnj merged commit 0238adf into develop Jan 17, 2025
17 checks passed
@mcdonnnj mcdonnnj deleted the bug/update_missed_comment branch January 17, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality documentation This issue or pull request improves or adds to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants