Skip to content

Conversation

@akwaed
Copy link

@akwaed akwaed commented Oct 16, 2024

Description

This PR is to update the LIFL's documentation, including how to setup the environment and deps. This PR also includes several minor fixes on dependency issue caused by pip update and also documentation on how to run the coord_hier_syncfl_mnist example.

Also added doc on how to install dependencies on a /mnt/ drive

Note that by not including a description, you are asking reviewers to do extra work to understand the context of this
change, which may lead to your PR taking much longer to review, or result in it not being reviewed at all.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@akwaed akwaed changed the title Update LIFL Documentation i Update LIFL Documentation Oct 16, 2024
@akwaed
Copy link
Author

akwaed commented Oct 16, 2024

This PR fixes issue #613

Copy link
Contributor

@myungjin myungjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akwaed Thank you for your interest and contribution. One comment was left. Can you please address it?


logger.debug("channel leave completed gracefully")

# def leave(self, channel) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove these commented lines?

@myungjin
Copy link
Contributor

@ShixiongQi For your attention.

@ShixiongQi
Copy link
Collaborator

@ShixiongQi For your attention.

I will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants