-
Notifications
You must be signed in to change notification settings - Fork 500
Make code work using NSS in FIPS-mode #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nils-ohlmeier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good to me, but I think we need a review with crypto expertise like @bifurcation here.
|
@msirringhaus you can ignore the fuzzing test for now, but please fix the other failures so we can get a review and move forward. Thanks |
|
Sorry, I pushed to early and had to fix the formatting again. |
and I approved to quickly :) |
This is part of an effort to make webRTC calls work under FIPS in Firefox. (See here and more specifically here)
How to test:
Half the tests fail without this patch and all work with it (tests also work with unset
NSS_FIPS).PK11_ImportSymKey()is not allowed to be used under FIPS, but there can be a workaroud to still be able to import raw key material, by encrypting it first and then unwrapping it (which is in the end a NO-OP, but satisfies the API under FIPS).