Don't re-write root logger log level #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the way that constants.py installs coloredlogs causes it to override the root logger to DEBUG, as well as enabling coloredlogs on the root logger, which can be undesirable. To fix that, instead we pass the (already created) logger instance into the install command, so that only log levels and coloring for that logger are modified.
|
@dachafra Hope you don't mind me popping in here, just a small QOL fix if you're open to it. |
|
sure @snakingfire, thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the way that constants.py installs coloredlogs causes it to override the root logger to DEBUG, as well as enabling coloredlogs on the root logger, which can be undesirable. To fix that, instead we pass the (already created) logger instance into the install command, so that only log levels and coloring for that logger are modified.