remove code smells #1220
Merged
remove code smells #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbortt
added
Type: Maintenance
Prio: Medium
State: Review
|
ok, sorry. this requires some more work. |
bbortt
force-pushed
the
fix/remove-code-smells
branch
3 times, most recently
from
389fcf8
to
3f086a9
Compare
|
@christophd can you please check that I did allright in the second commit? I think the first is less critical. thanks for the review! |
bbortt
force-pushed
the
fix/remove-code-smells
branch
from
3f086a9
to
f6b9d2b
Compare
|
@christophd I've rebased it and fixed the merge conflicts. |
|
CI job is flaky. I'll have a look |
|
@christophd let me know if you've fixed it. #1232 would be a good addition to the next release as well. |
* unused imports * unnecessary assignments or initializations * usages of `Arrays#asList` with single arguments * inner classes that weren't static
additionally, make sure all task executors are being shutdown properly.
bbortt
force-pushed
the
fix/remove-code-smells
branch
from
f6b9d2b
to
e4194d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed some code "smells"...
Arrays#asListwith single argumentsadditionally: