Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #929: fix set charset for request content #1247

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Issue #929: fix set charset for request content #1247

merged 1 commit into from
Nov 6, 2024

Conversation

phos-web
Copy link
Contributor

Get encoding charset from HTTP headers or fallback to UTF-8

bbortt
bbortt requested changes Nov 2, 2024
View reviewed changes
Copy link
Collaborator

@bbortt bbortt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you. I think one or two more checks would be valid. but it shouldn't be far from the final solution.

closes #929.

...us-http/src/test/java/org/citrusframework/http/interceptor/LoggingClientInterceptorTest.java Show resolved Hide resolved
...citrus-http/src/main/java/org/citrusframework/http/interceptor/LoggingClientInterceptor.java Outdated Show resolved Hide resolved
...citrus-http/src/main/java/org/citrusframework/http/interceptor/LoggingClientInterceptor.java Show resolved Hide resolved
@bbortt
Copy link
Collaborator

bbortt commented Nov 6, 2024

/lgtm

@bbortt bbortt added Type: Bug Prio: High State: Review If pull-request has been opened an is ready/in review labels Nov 6, 2024
@bbortt bbortt merged commit e35182d into citrusframework:main Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbortt bbortt bbortt approved these changes

Assignees

@phos-web phos-web

Labels
Prio: High State: Review If pull-request has been opened an is ready/in review Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phos-web @bbortt