Skip to content

Commit

Permalink
Ruleutils_17 Revert recent SQL/JSON related commits
Browse files Browse the repository at this point in the history
Reverts 8ad3592
def847f

Relevant PG commit:
postgres/postgres@eef5195
eef5195f300bb9cf2864d48761c0db2ad93842c1
  • Loading branch information
naisila committed Nov 10, 2024
1 parent def847f commit 3447abc
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/backend/distributed/deparser/ruleutils_17.c
Original file line number Diff line number Diff line change
Expand Up @@ -8495,6 +8495,7 @@ get_json_table_columns(TableFunc *tf, JsonTablePathScan *scan,
bool showimplicit)
{
StringInfo buf = context->buf;
JsonExpr *jexpr = castNode(JsonExpr, tf->docexpr);
ListCell *lc_colname;
ListCell *lc_coltype;
ListCell *lc_coltypmod;
Expand Down Expand Up @@ -8547,10 +8548,6 @@ get_json_table_columns(TableFunc *tf, JsonTablePathScan *scan,
if (ordinality)
continue;

/*
* Set default_behavior to guide get_json_expr_options() on whether to
* to emit the ON ERROR / EMPTY clauses.
*/
if (colexpr->op == JSON_EXISTS_OP)
{
appendStringInfoString(buf, " EXISTS");
Expand All @@ -8574,6 +8571,9 @@ get_json_table_columns(TableFunc *tf, JsonTablePathScan *scan,
default_behavior = JSON_BEHAVIOR_NULL;
}

if (jexpr->on_error->btype == JSON_BEHAVIOR_ERROR)
default_behavior = JSON_BEHAVIOR_ERROR;

appendStringInfoString(buf, " PATH ");

get_json_path_spec(colexpr->path_spec, context, showimplicit);
Expand Down Expand Up @@ -8651,7 +8651,7 @@ get_json_table(TableFunc *tf, deparse_context *context, bool showimplicit)
get_json_table_columns(tf, castNode(JsonTablePathScan, tf->plan), context,
showimplicit);

if (jexpr->on_error->btype != JSON_BEHAVIOR_EMPTY_ARRAY)
if (jexpr->on_error->btype != JSON_BEHAVIOR_EMPTY)
get_json_behavior(jexpr->on_error, context, "ERROR");

if (PRETTY_INDENT(context))
Expand Down

0 comments on commit 3447abc

Please sign in to comment.