handle when there are no changes

cityofaustin · Nov 14, 2023 · 6ee7025 · 6ee7025
1 parent c7b90b7
commit 6ee7025
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/moped-editor/src/utils/activityLogFormatters/mopedComponentsActivity.js b/moped-editor/src/utils/activityLogFormatters/mopedComponentsActivity.js
@@ -128,6 +128,11 @@ export const formatComponentsActivity = (
     }
   });
 
+  // handle an edge case where only ignored fields were edited
+  if (changes.length === 0) {
+    return { changeIcon: null, changeText: null };
+  }
+
   return {
     changeIcon,
     changeText: [

diff --git a/moped-editor/src/views/projects/projectView/ProjectActivityLog.js b/moped-editor/src/views/projects/projectView/ProjectActivityLog.js
@@ -230,6 +230,11 @@ const ProjectActivityLog = () => {
                     lookupData,
                     projectId
                   );
+                  // allows log formatters to return a `null` changeText, causing the
+                  // event to not be rendered at all
+                  if (!changeText) {
+                    return null;
+                  }
                   return (
                     <TableRow key={change.activity_id}>
                       <TableCell