-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Funding program field added advanced search filter #1435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting an error field 'funding_program_names' not found in type: 'project_list_view_bool_exp'
, it looks like I'm missing the updated metadata file with the permissions for the new column.
After I added that permission locally, I was able to continue testing and it all works out as expected, I'll approve after the permissions issue gets sorted
Thanks for the feedback and guidance @chiaberry. Permissions have been updated via the metadata so it should be squared away for you to finalize your review. Thanks again! |
moped-database/migrations/1727458564792_add_funding_program_to_project_list_view/down.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks amazing! I tested the advanced search and migrations, and all works beautifully! 🚢 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great + works great! 🚢
yes, it's 1k+ lines of code to add a column to a table, but at least we don't have to update the typescript interface, too 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great mateo and it works like a charm!! ✨ 🚢
Associated issues
cityofaustin/atd-data-tech#18763
Funding programs added to advanced filter
Filtered view with chip
Testing
Need to test locally due to view table update
Steps to test:
Ship list