Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Funding program field added advanced search filter #1435

Merged
merged 5 commits into from
Oct 4, 2024

Conversation

mateoclarke
Copy link
Contributor

@mateoclarke mateoclarke commented Sep 27, 2024

Associated issues

cityofaustin/atd-data-tech#18763

Funding programs added to advanced filter

Screenshot 2024-09-27 at 5 01 54 PM

Filtered view with chip

Screenshot 2024-09-27 at 5 01 38 PM

Testing

Need to test locally due to view table update

Steps to test:

  • Run migrations
  • Replicate prod data (optional)
  • On the "Projects" tab, make sure the "Funding" Column is visible in the Project List table.
  • Using advanced filter in the Search bar, add a filter on the Field "Funding programs"
  • Confirm the Operator defaults to "contains"
  • Select an option from the dropdown (Ex: "Pedestrian Crossing") & Apply
  • Confirm Project List is filtered as expected with the Filter chip visible below the search.

Ship list

Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting an error field 'funding_program_names' not found in type: 'project_list_view_bool_exp', it looks like I'm missing the updated metadata file with the permissions for the new column.

After I added that permission locally, I was able to continue testing and it all works out as expected, I'll approve after the permissions issue gets sorted

@mateoclarke
Copy link
Contributor Author

I'll approve after the permissions issue gets sorted

Thanks for the feedback and guidance @chiaberry. Permissions have been updated via the metadata so it should be squared away for you to finalize your review. Thanks again!

@mddilley mddilley self-requested a review October 3, 2024 20:07
Copy link
Collaborator

@mddilley mddilley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! I tested the advanced search and migrations, and all works beautifully! 🚢 🙌

Copy link
Member

@johnclary johnclary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great + works great! 🚢

yes, it's 1k+ lines of code to add a column to a table, but at least we don't have to update the typescript interface, too 😛

Copy link
Member

@chiaberry chiaberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Copy link
Contributor

@roseeichelmann roseeichelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great mateo and it works like a charm!! ✨ 🚢

@mateoclarke mateoclarke merged commit caa2f0c into main Oct 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants