Skip to content

feat(instance): add VNC session management commands #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 12, 2025
Merged

Conversation

uzaxirr
Copy link
Contributor

@uzaxirr uzaxirr commented Jun 10, 2025

fixes: #537

@uzaxirr uzaxirr self-assigned this Jun 10, 2025
@uzaxirr uzaxirr requested a review from giornetta June 10, 2025 07:47
@uzaxirr
Copy link
Contributor Author

uzaxirr commented Jun 10, 2025

Screenshot 2025-06-10 at 1 48 53 PM

@giornetta
Copy link
Member

This is an output I'm receiving for civo instance vnc status my-instance:

Instance ID : {instance_uuid}
Instance Hostname : my-instance
           Status :
              URI : https://vnc.lon1.civo.com/...
           Expiry : 2025-06-11T11:42:12Z

What's the point of the empty Status field?

@uzaxirr
Copy link
Contributor Author

uzaxirr commented Jun 12, 2025

This is an output I'm receiving for civo instance vnc status my-instance:

Instance ID : {instance_uuid}
Instance Hostname : my-instance
           Status :
              URI : https://vnc.lon1.civo.com/...
           Expiry : 2025-06-11T11:42:12Z

What's the point of the empty Status field?

As of now we are reciving its reponse as empty from the API, i've mapped status to vnc.Result field

@giornetta
Copy link
Member

As of now we are reciving its reponse as empty from the API,

There's no such field in the API response. The only field returned by the API are uri and expiration.

Copy link
Member

@giornetta giornetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giornetta giornetta merged commit 7d031d8 into master Jun 12, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement new commands for Console endpoints
3 participants