refactor: reduce bundle size #544
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- lumos dependencies and modules are really a bit much - contributors often depend on yarn's auto-hoist to cause some module to not be installed correctlly
the docker is no longer needed
# Conflicts: # packages/ckb-indexer/package.json # packages/common-scripts/package.json # packages/debugger/package.json # packages/e2e-test/package.json # packages/experiment-tx-assembler/package.json # packages/hd-cache/package.json # packages/helpers/package.json # packages/transaction-manager/package.json
# Conflicts: # .github/workflows/ci.yaml # .github/workflows/publish.yml # DEVELOPMENT.md # README.md # commitlint.config.js # examples/README.md # examples/cardano-lock-namiwallet/package.json # examples/exchange-sudt-for-ckb/package.json # examples/omni-lock-metamask/package.json # examples/omni-lock-secp256k1-blake160/package.json # examples/pw-lock-metamask/package.json # examples/secp256k1-transfer/package.json # package.json # packages/bi/package.json # packages/ckb-indexer/package.json # packages/codec/package.json # packages/common-scripts/package.json # packages/config-manager/package.json # packages/debugger/package.json # packages/e2e-test/package.json # packages/experiment-tx-assembler/package.json # packages/hd-cache/package.json # packages/hd/package.json # packages/helpers/package.json # packages/light-client/package.json # packages/lumos/package.json # packages/molecule/package.json # packages/rpc/package.json # packages/runner/package.json # packages/testkit/package.json # packages/toolkit/package.json # packages/transaction-manager/examples/chained-transfer-example/package.json # packages/transaction-manager/package.json # packages/utils/package.json # pnpm-lock.yaml # website/package.json
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #544 +/- ##
===========================================
+ Coverage 86.35% 86.43% +0.08%
===========================================
Files 114 118 +4
Lines 22917 23053 +136
Branches 2310 2328 +18
===========================================
+ Hits 19790 19926 +136
Misses 3084 3084
Partials 43 43
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #516
This PR
require("crypto")to import by demandlodash.isequal