feat: enable validate duck typing #598
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #598 +/- ##
===========================================
+ Coverage 87.29% 87.30% +0.01%
===========================================
Files 118 118
Lines 23983 23984 +1
Branches 2459 2469 +10
===========================================
+ Hits 20935 20939 +4
- Misses 3003 3004 +1
+ Partials 45 41 -4
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
Great!! What's the best way to test this PR with my typescript code? 🤔 |
|
@homura if you want I can open a dedicated question to how to import a Lumos PR and you can reply there, so it's easier to find for future L1 developers, just let me know!! |
It will automatically be released as a canary once the PR is reviewed and merged |
# Conflicts: # packages/base/package.json # packages/ckb-indexer/package.json # packages/common-scripts/package.json # packages/e2e-test/package.json # packages/experiment-tx-assembler/package.json # packages/helpers/package.json # packages/lumos/package.json # packages/transaction-manager/package.json # pnpm-lock.yaml
Description
Fixes #594
This PR supports duck typing by switching to
codecasvalidatorsto check CKB-related objects. It also removes the unnecessarytoolkitdep in related modulesType of change
Please delete options that are not relevant.
How Has This Been Tested?