Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supports sighashall and sighashallonly for cobuild #661

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

feat: supports sighashall and sighashallonly for cobuild #661

wants to merge 6 commits into from

Conversation

homura
Copy link
Collaborator

@homura homura commented Apr 2, 2024 •
edited
Loading

Description

Fixes #652

This PR introduces the SighashAll and SighashAllOnly variants of the CoBuild protocol for Lumos. An example was included to demonstrate how the human-readable message work with the CoBuild protocol

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Unit test
  • example & manual test

@vercel Vercel
Copy link

vercel bot commented Apr 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
lumos-website ✅ Ready (Inspect) Visit Preview Apr 3, 2024 9:33am

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.75810% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 87.43%. Comparing base (4edfce4) to head (ad38a37).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #661      +/-   ##
===========================================
+ Coverage    84.30%   87.43%   +3.13%     
===========================================
  Files          121      129       +8     
  Lines        24574    24974     +400     
  Branches      2364     2564     +200     
===========================================
+ Hits         20717    21837    +1120     
+ Misses        3816     3095     -721     
- Partials        41       42       +1
Files Coverage Δ
packages/cobuild/src/codec.ts 100.00% <100.00%> (ø)
packages/cobuild/src/generated/basic.ts 100.00% <100.00%> (ø)
packages/cobuild/src/generated/top_level.ts 100.00% <100.00%> (ø)
packages/cobuild/src/hash.ts 100.00% <100.00%> (ø)
packages/cobuild/src/index.ts 100.00% <100.00%> (ø)
packages/cobuild/src/shared-codecs.ts 100.00% <100.00%> (ø)
packages/common-scripts/src/omnilock-cobuild.ts 100.00% <100.00%> (ø)
packages/common-scripts/src/omnilock.ts 91.19% <100.00%> (+0.04%) ⬆️
packages/debugger/src/context.ts 92.43% <100.00%> (ø)
packages/cobuild/src/sighash.ts 92.30% <92.30%> (ø)

... and 11 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edfce4...ad38a37. Read the comment docs.

@Keith-CY
Copy link
Member

Keith-CY commented Apr 6, 2024

Please make it ready for review if we can start the code review

@homura homura marked this pull request as ready for review April 6, 2024 05:55
@homura homura changed the title [HOLD ON BEFORE 0.22 RELEASE] feat: supports sighashall and sighashallonly for cobuild feat: supports sighashall and sighashallonly for cobuild Apr 7, 2024
PainterPuppets
PainterPuppets approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@PainterPuppets PainterPuppets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Keith-CY
Keith-CY reviewed Apr 12, 2024
View reviewed changes
examples/cobuild-sighash/README.md
@@ -0,0 +1,18 @@
# CoBuild Sighash Example

This code example demonstrates how to use `@ckb-lumos/cobuild` with a lock that supports the CoBuild protocol. We will be working with a fake schema for the sUDT script to mint sUDT through a human-readable signing message.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to demonstrate it with xUDT because it's the mainly promoted token protocol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on this conversation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be going on, but the launch of CoBuild will be postponed and it's expected to change, so the PR has been slowed down

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@homura
Copy link
Collaborator Author

homura commented Jun 11, 2024

The CoBuild is temporarily suspended

@homura homura marked this pull request as draft June 11, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY left review comments

@PainterPuppets PainterPuppets PainterPuppets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SighashAll and SighashAllOnly variant of the CoBuild protocol through Omnilock
3 participants
@homura @Keith-CY @PainterPuppets