-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lumos crypto.randomBytes to replace node's #701
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #701 +/- ##
===========================================
+ Coverage 85.67% 87.06% +1.38%
===========================================
Files 131 132 +1
Lines 25247 25246 -1
Branches 2663 2738 +75
===========================================
+ Hits 21631 21981 +350
+ Misses 3576 3225 -351
Partials 40 40
... and 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Tom Wang <[email protected]>
@homura Can this PR be merged into |
Not yet. We'll publish 0.23 first |
Signed-off-by: Tom Wang <[email protected]>
Let's merge this and move forward. |
Maybe it's better to target this PR to the 'browser-compatibility' branch first until the node modules, such as 'buffer' and 'crypto', are fully dropped. Then, check if it works properly with Vite, CRA, and Next.js. |
The plan is to replace Node crypto first, then replace Now the first PR is done, and it's safe to merge it. The second is ready locally. metioned in #645 |
I will merge this PR into a newly created branch |
Description
ckb-lumos/crypto
package which has arandomBytes
method to replace nodecrypto.randomBytes
.ckb-lumos/crypto
inckb-lumos/lumos
Type of change
How Has This Been Tested?
Unit tests