Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The GCP provider was broken. It seems the multi-instance config feature wasn’t implemented in the GCP provider.
Also, the
GCP_SA_JSON
environment variable wasn’t properly loaded into the config. The current implementation only usesGCP_SERVICE_ACCOUNT_KEY
as the credential provider, so I added support for loading credentials from a file path.Type of Change
Testing
I followed the instructions in TESTING.md and also used a proxy locally.
Checklist
pytest
locally and all tests passImportant Note
All PRs must pass the automated test suite before they can be merged. The GitHub Actions workflow will automatically run
pytest
on your changes using thepython-app-testing.yml
workflow.