Skip to content

Fix GCP provider #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix GCP provider #91

wants to merge 4 commits into from

Conversation

Calvin-Huang
Copy link

@Calvin-Huang Calvin-Huang commented May 15, 2025

Pull Request

Description

The GCP provider was broken. It seems the multi-instance config feature wasn’t implemented in the GCP provider.

Also, the GCP_SA_JSON environment variable wasn’t properly loaded into the config. The current implementation only uses GCP_SERVICE_ACCOUNT_KEY as the credential provider, so I added support for loading credentials from a file path.

Type of Change

  • Bug fix
  • New feature
  • Enhancement to existing functionality
  • Documentation update

Testing

I followed the instructions in TESTING.md and also used a proxy locally.

Checklist

  • I've run pytest locally and all tests pass
  • I've added tests for new functionality (if applicable)
  • My code follows the project's style
  • I've updated documentation if needed

Important Note

All PRs must pass the automated test suite before they can be merged. The GitHub Actions workflow will automatically run pytest on your changes using the python-app-testing.yml workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant