Split Repository Based On Entities #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivachandran
requested changes
Mar 29, 2021
Contributor
sivachandran
left a comment
sivachandran
left a comment
There was a problem hiding this comment.
I added comments only for ServiceRequestRepository. But if you agree with the comment then you can other repositories as well.
| @@ -0,0 +1,35 @@ | |||
| package repository | |||
Contributor
There was a problem hiding this comment.
you can name the file as just service_request.go. the word repository is already part of the package name.
| "github.com/prometheus/common/log" | ||
| ) | ||
|
|
||
| type servicerequestrepositorypostgres struct { |
Contributor
There was a problem hiding this comment.
you can move postgres specific implementation to under postgres subpackage and name the struct as ServiceRequestRepository. So, in the above init function we will have serviceRequestRepository = postgres.ServiceRequestRepository
| for stepResponse := range resumeStepsChannel { | ||
| prefix = fmt.Sprintf("%s [REQUEST_ID: %s]", prefix, stepResponse.ServiceRequestID) | ||
| log.Debugf("%s : Received step response : %v", prefix, stepResponse) | ||
| log.Infof("%s : Received step response : %v", prefix, stepResponse) |
Contributor
There was a problem hiding this comment.
Logs in hot code path decreases the RPS. You can revert the change if there are no other specific reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.