Skip to content

move read_t to binary.py namespace #745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025
Merged

Conversation

bolliger32
Copy link
Contributor

Addresses #744 by moving read_t such that it is in the module namespace. I'm not aware of why read_t was imported within the read function to begin with, so I'm not sure if this is going to create other issues. Someone with more of an understanding of pyclaw should probably take a look at this before anything gets merged.

@coveralls
Copy link

Coverage Status

coverage: 46.613% (+0.02%) from 46.591%
when pulling 7a527f6 on bolliger32:bugfix/read-t
into 60de625 on clawpack:master.

@ketch
Copy link
Member

ketch commented Jun 12, 2025

Yes, it seems that several bits of code expect read_t to be available in the way that this PR would make it. Indeed, prior to 6e284b9, it was available there. I think when that change was made, we must not have realized that code outside of binary.py depended on this.

Thanks for catching this issue and fixing it!

@ketch ketch merged commit 480c35d into clawpack:master Jun 12, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants