Update AuthenticateRequest to support Minimal APIs#25
Open
iamadamreed wants to merge 1 commit intoclerk:mainfrom
Open
Update AuthenticateRequest to support Minimal APIs#25iamadamreed wants to merge 1 commit intoclerk:mainfrom
iamadamreed wants to merge 1 commit intoclerk:mainfrom
Conversation
feat(auth): Add ASP.NET Core HttpRequest overload for AuthenticateRequest Add method overload to Clerk's AuthenticateRequest class to directly support ASP.NET Core HttpRequest objects without conversion. This improves compatibility with Minimal APIs and Native AOT compilation by: - Eliminating complex request conversion between HttpRequest and HttpRequestMessage - Reducing object allocations for better performance - Maintaining the same security validation logic as the original method - Supporting direct extraction of auth tokens from HttpRequest objects This change allows for cleaner integration with ASP.NET Core Minimal APIs while preserving the existing functionality for HttpRequestMessage scenarios.
iamadamreed
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(auth): Add ASP.NET Core HttpRequest overload for AuthenticateRequest
Add method overload to Clerk's AuthenticateRequest class to directly support ASP.NET Core HttpRequest objects without conversion. This improves compatibility with Minimal APIs and Native AOT compilation by:
This change allows for cleaner integration with ASP.NET Core Minimal APIs while preserving the existing functionality for HttpRequestMessage scenarios.