feat: Support is_secondary for domain updates to indicate that the su… #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bdomain is significant If `is_secondary` is `true` and the application supports it, then the full domain name provided will be stored as the domain, including any subdomain(s). i.e. we will not be storing the eTLD+1 as the domain in case a subdomain is provided.
kostaspt
approved these changes
Aug 20, 2024
yourtallness
deleted the
yourtallness/support_is_secondary_for_domain_updates_2nd_try
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bdomain is significant
If
is_secondaryistrueand the application supports it, then the full domain name provided will be stored as the domain, including any subdomain(s).i.e. we will not be storing the eTLD+1 as the domain in case a subdomain is provided.