Skip to content

fix(clerk-js): Plan card fixes #5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

aeliox
Copy link
Contributor

@aeliox aeliox commented May 6, 2025

Description

Fix footer/notice/button rendering within plan cards

No subs yet

Screenshot 2025-05-07 at 1 10 32 PM

1 active sub

Screenshot 2025-05-07 at 1 10 59 PM

1 active sub, 1 upcoming sub

Screenshot 2025-05-07 at 1 11 35 PM

Active montly sub and toggle to annual

Monthly plan period Annual plan period
Screenshot 2025-05-07 at 1 12 21 PM Screenshot 2025-05-07 at 1 12 57 PM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented May 6, 2025

🦋 Changeset detected

Latest commit: ca55a95

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2025 4:21pm

Copy link
Member

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Causing checkout to open with active plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants