Skip to content

Comments

Enable cacheable-lookup v7 and add DNS lookup coverage#8

Merged
dimikot merged 2 commits intoclickup:mainfrom
mbaczynski-cu:dev/mbaczynski-cu/add-cacheable-lookup
Feb 20, 2026
Merged

Enable cacheable-lookup v7 and add DNS lookup coverage#8
dimikot merged 2 commits intoclickup:mainfrom
mbaczynski-cu:dev/mbaczynski-cu/add-cacheable-lookup

Conversation

@mbaczynski-cu
Copy link
Contributor

Summary

  • replace direct dns.lookup usage with cacheable-lookup, while keeping CommonJS/Node16 compatibility via cached dynamic import in RestRequest
  • update Jest config to support ESM dependency transformation (babel-jest + pnpm-aware transformIgnorePatterns) and add babel.config.js
  • add focused DNS/cacheable-lookup tests and close shared test servers in afterAll to remove open-handle warnings (also remove forceExit)

Test plan

  • pnpm build
  • pnpm lint
  • pnpm test
  • pnpm exec jest --detectOpenHandles --runInBand

Made with Cursor

mbaczynski-cu and others added 2 commits February 19, 2026 15:20
Replace direct dns.lookup() calls with cacheable-lookup to reuse DNS answers and reduce repeated resolution overhead in request execution.

Co-authored-by: Cursor <[email protected]>
Add Babel-based Jest transforms for ESM node_modules support, keep RestRequest on dynamic cacheable-lookup loading, add tests for runtime loading plus family-specific lookupAsync usage, keep TypeScript Node16 build compatibility, and close test servers to eliminate Jest open-handle warnings.

Co-authored-by: Cursor <[email protected]>
@dimikot dimikot merged commit 6ead06d into clickup:main Feb 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants