Fix issue #30 Unicode decoding in conversion to CharSequence #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #30 affects us too, so I've looked a bit into it.
CharseDecoder
's JavaDoc is somewhat vague, but it states that:It looks like in case of underflow during the decode operation
CharsetDecoder
leaves bytes not constituting a full character in the passed input and expects next decode operation to pass these bytes along with additional ones which together form a full character. So I've added merging of the remainingextra-bytes
and newin
to the undeflow branch of the decoding. It fixes the issue, but I'm not that experienced with byte fiddling, so maybe there is a more effective way to do that.In case compatibility with Clojure 1.5 is needed, I can remove usage of
some->
(the same goes forsome?
and Clojure < 1.5).Test could be found in pull request #31.