def-transfer: emit correct :tag metadata
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reoccurrences are prevented by introducing Eastwood as a linter, which detected this issue in the first place. Fixes clj-commons#45
slipset
reviewed
Jun 14, 2021
src/byte_streams.clj
Outdated
| (defmacro def-conversion | ||
| "Defines a conversion from one type to another." | ||
| [[src dst :as conversion] params & body] | ||
| (let [^Type src (normalize-type-descriptor src) | ||
| dst (normalize-type-descriptor dst)] | ||
| dst (normalize-type-descriptor dst) | ||
| src-meta (if-let [c (extract-class src)] |
There was a problem hiding this comment.
Would it make sense to have a fn like (class-meta src)
(defn class-meta [^Type src]
(if-let [c (extract-class src)
{:tag c}
{}))or some variant of that? Maybe extract-class could be inlined?
|
Thanks for the review! Fixed |
slipset
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reoccurrences are prevented by introducing Eastwood as a linter, which detected this issue in the first place.
Fixes #45