Replace deprecated single-segment ns w Potemkin's import-vars

[KingMob]

Obviously, this introduces a dependency on Potemkin, but Aleph already needs it, and Potemkin has barely changed in years.

[KingMob]

Fixes #65

[KingMob]

@p-himik can you try this out?

[arnaudgeiser]

It's looking good.
It means we'll have to release a new version of Aleph with this change.
It was also causing us some issues, but as we were aware of the work that has been done on byte-streams, it was easy to do the migration on our side.

[KingMob]

Fair point. I held off because I was debating whether to kill the top-level test namespaces entirely. Insofar as they test behavior, there's now no way the top-level tests can fail but the clj-commons tests will succeed. But they *do* still test that the fns are available and callable. Even if I kill the other tests, I suppose I should keep that one around

…

On Thu, Dec 22, 2022 at 2:38 PM Arnaud Geiser ***@***.***> wrote: ***@***.**** approved this pull request. It's looking good. It means we'll have to release a new version of Aleph with this change. It was also causing us some issues, but as we were aware of the work that has been done on byte-streams, it was easy to do the migration on our side. ------------------------------ In src/byte_streams.clj <#66 (comment)> : > + ;; compare the namespaces, make sure we got everything + (require '[clojure.set :as set]) + + (set/difference Maybe this can be turned into a Clojure test and the whole comment block can be removed. — Reply to this email directly, view it on GitHub <#66 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHHB5NT7NBFCUQLUM7C3BTWOPZNLANCNFSM6AAAAAATGK7ERY> . You are receiving this because you authored the thread.Message ID: ***@***.***>